Fix missing paginator in the inspector #1843
Merged
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conditions to determine whether a Morph has a fixed width or height.
Contributor
|
@estebanlm can I integrate this PR because the navigation is too cool to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paginator was not displayed correctly due to a mistake in PR #1813, which was intended to fix #1735. In
SpMorphicBoxAdapter>>#verifyBoxExtentOf:withChild:, the conditions to determine whether a Morph has a fixed width or fixed height were not correct.This PR fixes the mistake. It sets the min width and max width (or min height and max height if the SpBoxLayout direction is vertical) when the SpBoxConstraints specify a width (or height). The same value for the min width and the max width (or the min height and the max height) indicates that a Morph has fixed size, which can be taken into account when laying out the submorphs of a box layout.
@estebanlm reviewed the initial suggestion for a solution. This PR takes his review comments into account. All changes are made in
SpMorphicBoxAdapter.