Skip to content

Fix code presenter Browse Implementors #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jecisc merged 1 commit into from
Jun 25, 2026
Merged

Fix code presenter Browse Implementors #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Spec2-Code/SpCodePresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,17 @@ SpCodePresenter >> doBrowseHierarchy [

{ #category : 'commands' }
SpCodePresenter >> doBrowseImplementors [

| variableOrClassName variable |

variableOrClassName := self selectedSelector ifNil: [ ^ nil ].
variable := self lookupEnvironment lookupVar: variableOrClassName.

"For global and class variables, implementors-of browses the class of the value of the variable,
for classes this means it browses the class"
(variable isNotNil and: [variable isGlobalVariable or: [variable isClassVariable]])
(variable isNotNil and: [ variable isGlobalVariable or: [ variable isClassVariable ] ])
ifTrue: [ self systemNavigation browse: variable value ]
ifFalse: [ self systemNavigation browseAllImplementorsOf: variableOrClassName ]
ifFalse: [
(Smalltalk tools toolNamed: #messageList) browseImplementorsOfAll: { variableOrClassName } from: self interactionModel behavior ]

@guillep guillep Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right fix should be to pass though system navigation here, as it was before.

If we need to add an argument for the origin class, that should be extended there too.
And maybe we need to support the old method too for some time as a compatibility measure.

@guillep guillep Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the cause of the failing tests:

  • SpCodePresenterTest testDoBrowseSenders
  • SpCodePresenterTest testDoBrowseSendersOfClassNameShouldNotFindIfNotInEnvironment
  • SpCodePresenterTest testDoBrowseSendersOfClassNameWhenInPlaygroundButNotAvailable
  • SpCodePresenterTest testDoBrowseSendersOfClassPoolVariableShouldSelectClassPoolVariableUsersWhenInDebuggerButNotAvailable
  • SpCodePresenterTest testDoBrowseSendersOfClassVariableShouldSelectClassVariableUsersWhenInDebuggerButNotAvailable
  • SpCodePresenterTest testDoBrowseSendersOfClassVariableShouldSelectClassVariableUsersWhenInStaticContextButNotAvailable

]

{ #category : 'commands' }
Expand Down
Loading