Conversation
codeit-ninja
left a comment
There was a problem hiding this comment.
See my comment in the reviewed file, thank you.
| @@ -1,10 +1,8 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Why are these lines removed? Could you explain what the reason is behind it without me having to figure it out on my own? Thank you :)
|
Can we merge this after review please? This is a very good addition .. This also closes both the issues as they seem to relate to what the author of this PR fixed. Edit: Why is this PR not merged yet? Maybe issues that need to be resolved? |
|
@codeit-ninja Unfortunately, this hits the limit of what typescript can handle in terms of nested types. Will need to look into flattening some of the structures there but it's a little complicated to get right. |
|
@phenax It seems to work correctly in my project, I dont hit any limitations? It correctly shows optional groups, in the picture |
|
@codeit-ninja it works for some expressions but there are a lot of cases where ts errors out |
|
@phenax Thats odd, I dont get this warning/error What TS version are you using? I am on |



WIP. Will need to re-write the parser to work better with nested groups without nesting the types to its limits