Skip to content

Conversation

@otomist
Copy link

@otomist otomist commented Nov 24, 2025

1 character change: fix typo noRepat -> noRepeat

Found a typo in the closeOtherTabs command in all_commands.js while working on my own feature. Thought I should put in a pr.

All tests still pass with ./make.js test

@philg-dev
Copy link
Contributor

Looks good to me. I did not test this change locally, but from looking at the code base, it looks correct.

I assume in the current master with that typo it would be possible to repeat the command if prefixed with a number (count). As a reference, the related commands above don't have the noRepeat property and they are intended to be repeated, while for the closeOtherTabs repeating makes no sense. Since the outcome of applying the command once vs. multiple times is the same, there should not be any semantic difference from the fixed typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants