Added crucial comment in fine-tune-embedding-model-for-rag.ipynb #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a valuable comment, as one codesnippet was really confusing, as we used the test and train-splits for the document pool but we have to treat both as `train` splits, when loading from JSON, because there wouldn't be a predefined split called `test`. **Summary:** The code is correct but it looks like a typo when having to variables `test_dataset` and `train_dataset` but both use the split `train`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trainsplits, when loading from JSON, because there wouldn't be a predefined split calledtest. Summary: The code is correct but it looks like a typo when having two variables:test_datasetandtrain_datasetbut both use the splittrain