Fixed #165. Fixed a bug where multiplication with zero caused an error#174
Open
akerfel wants to merge 1 commit intophishman3579:masterfrom
Open
Fixed #165. Fixed a bug where multiplication with zero caused an error#174akerfel wants to merge 1 commit intophishman3579:masterfrom
akerfel wants to merge 1 commit intophishman3579:masterfrom
Conversation
…so it now can handle zero inputs, also modified the test to cover the case where there are several zeroes ('0000') in the input.
akerfel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
multiplyUsingLoopWithStringInputin Multiplication.java can now handle zero inputs. Also added branch coverage for this.See issue #165 for more details.
By submitting this pull request I confirm I've read and complied with the below requirements.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.