-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz 2. Update division functionality to include error handling for d… #262
Open
Sofia-Rimando
wants to merge
1
commit into
phishman3579:master
Choose a base branch
from
Sofia-Rimando:Q2_Sofia-Rimando
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,84 +4,116 @@ public class Division { | |
|
||
public static final long division(int a, int b) { | ||
long result = ((long) a) / ((long) b); | ||
|
||
if (b == 0) { | ||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
return result; | ||
} | ||
} | ||
|
||
public static final long divisionUsingLoop(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
long temp = absA; | ||
long result = 0; | ||
while (temp >= 0) { | ||
temp -= absB; | ||
if (temp >= 0) | ||
result++; | ||
} | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
if (b == 0) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above. Use else case to implement remaining mathematical functionality |
||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
long temp = absA; | ||
long result = 0; | ||
while (temp >= 0) { | ||
temp -= absB; | ||
if (temp >= 0) | ||
result++; | ||
} | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
} | ||
|
||
public static final long divisionUsingRecursion(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
long result = 1; | ||
int diff = absA - absB; | ||
if (diff > 0 && diff <= 1) { | ||
return result; | ||
} else if (diff < 0) { | ||
return 0; | ||
} | ||
if (b == 0) { | ||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
long result = 1; | ||
int diff = absA - absB; | ||
if (diff > 0 && diff <= 1) { | ||
return result; | ||
} else if (diff < 0) { | ||
return 0; | ||
} | ||
|
||
result += divisionUsingRecursion(diff, absB); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
result += divisionUsingRecursion(diff, absB); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
} | ||
|
||
public static final long divisionUsingMultiplication(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
int temp = absB; | ||
int counter = 0; | ||
while (temp <= absA) { | ||
temp = temp << 1; | ||
counter++; | ||
} | ||
absA -= absB << (counter - 1); | ||
long result = (long) Math.pow(2, counter - 1); | ||
if (absB <= absA) | ||
result += divisionUsingMultiplication(absA, absB); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
if (b == 0) { | ||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
int temp = absB; | ||
int counter = 0; | ||
while (temp <= absA) { | ||
temp = temp << 1; | ||
counter++; | ||
} | ||
absA -= absB << (counter - 1); | ||
long result = (long) Math.pow(2, counter - 1); | ||
if (absB <= absA) | ||
result += divisionUsingMultiplication(absA, absB); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
} | ||
|
||
public static final long divisionUsingShift(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
int tempA, tempB, counter; | ||
|
||
long result = 0L; | ||
while (absA >= absB) { | ||
tempA = absA >> 1; // Right shift "a" | ||
tempB = absB; | ||
counter = 1; | ||
while (tempA >= tempB) { // Double "tempB" until it's larger than | ||
// "tempA" | ||
tempB <<= 1; | ||
counter <<= 1; // Double the counter | ||
} | ||
absA -= tempB; // Subtract "tempB" from "a" | ||
result += counter; // Add counter (2^number of left shifts) | ||
} | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
if (b == 0) { | ||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
long result = 0L; | ||
while (absA >= absB) { | ||
tempA = absA >> 1; // Right shift "a" | ||
tempB = absB; | ||
counter = 1; | ||
while (tempA >= tempB) { // Double "tempB" until it's larger than | ||
// "tempA" | ||
tempB <<= 1; | ||
counter <<= 1; // Double the counter | ||
} | ||
absA -= tempB; // Subtract "tempB" from "a" | ||
result += counter; // Add counter (2^number of left shifts) | ||
} | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
} | ||
|
||
public static final long divisionUsingLogs(int a, int b) { | ||
long absA = Math.abs(a); | ||
long absB = Math.abs(b); | ||
double logBase10A = Math.log10(absA); | ||
double logBase10B = Math.log10(absB); | ||
double powOf10 = Math.pow(10, (logBase10A - logBase10B)); | ||
long result = (long) Math.floor(powOf10); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
|
||
if (b == 0) { | ||
throw new IllegalArgumentException ("Divisor cannot be 0"); | ||
} | ||
else { | ||
double logBase10A = Math.log10(absA); | ||
double logBase10B = Math.log10(absB); | ||
double powOf10 = Math.pow(10, (logBase10A - logBase10B)); | ||
long result = (long) Math.floor(powOf10); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement throw case for error handling. Check if input b is 0.