Preserve original name when as
is not provided to simple_form
#5975
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default
nil
value for theas
attribute in the generatedsimple_form
core component.This default interferes with the form name present in the form struct provided through the component's
for
attribute when used with:let=
.For example, consider the following code:
When rendered,
f.name
isnil
, and thename
attribute of the form field only containsbar
, missing the proper field name prefix from the form struct:This issue been reported over here.
Fixes #5901