Skip to content

Allow to specify the name of requirements.txt file #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kirsanium opened this issue Nov 4, 2022 · 2 comments
Open

Allow to specify the name of requirements.txt file #33

kirsanium opened this issue Nov 4, 2022 · 2 comments
Assignees
@php-coder
Labels
enhancement New feature or request lang/python

Comments

@kirsanium
Copy link
Contributor

При генерации кода в гитхаб экшнс затираются мои зависимости (например, я добавил pytz)
@php-coder php-coder self-assigned this Nov 7, 2022
@php-coder php-coder added the enhancement New feature or request label Nov 7, 2022
@php-coder php-coder added this to the 0.0.3 milestone Nov 7, 2022
php-coder added a commit that referenced this issue Nov 7, 2022
@php-coder
refactor: pass all options to the methods
96c24c4 
Part of #33
@php-coder
Copy link
Owner

php-coder commented Nov 7, 2022 •
edited
Loading

@kirsanium The default behavior has been changed to not overwrite files by default. In order to overwrite them, the new --overwrite option has been introduced.

@php-coder php-coder reopened this Nov 13, 2022
@php-coder php-coder mentioned this issue Nov 13, 2022
Closed
php-coder added a commit that referenced this issue Nov 13, 2022
@php-coder
revert: feat!: don't overwrite files by default to preserve user's mo…
2b51906 
…difications and introduce --overwrite option to turn this off

This reverts commit c78fdfa.

Relate to #33

This also fixes #34 because the code that caused error has been removed.
@php-coder
Copy link
Owner

--overwrite option has been removed as it doesn't solve the issue properly:

  1. when we have a generated app and we modified only one file (for example, requirements.txt), using --overwrite option lead us to the situation when no files generated at all. So, in fact, modification of one file exclude the application completely from auto generation
  2. the case when we want to have custom modifications to requirements.txt was still not addressed.

One way to solve this, was proposed by @kirsanium where we tell query2app to create requirements.txt with another name and include it from user managed requirements.txt with (-r option).

@php-coder php-coder changed the title Предоставить возможность изменять имя requirements.txt [python] Allow to specify the name of requirements.txt file Jun 9, 2023
@php-coder php-coder changed the title [python] Allow to specify the name of requirements.txt file Allow to specify the name of requirements.txt file Mar 13, 2024
@php-coder php-coder removed this from the 0.0.3 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
enhancement New feature or request lang/python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @kirsanium