Skip to content

Fix OEmbed for X.com (Twitter)#540

Merged
oscarotero merged 1 commit intophp-embed:masterfrom
snapeuh:master
Jul 24, 2024
Merged

Fix OEmbed for X.com (Twitter)#540
oscarotero merged 1 commit intophp-embed:masterfrom
snapeuh:master

Conversation

@snapeuh
Copy link
Copy Markdown
Contributor

@snapeuh snapeuh commented Jul 24, 2024

Hello,

I just edited two files to re-enable the OEmbed for x.com links.

Thanks for your work,

Regards,

Romain.

@oscarotero oscarotero merged commit 3a56bc2 into php-embed:master Jul 24, 2024
@oscarotero
Copy link
Copy Markdown
Collaborator

Thanks, Romain!

@snapeuh
Copy link
Copy Markdown
Contributor Author

snapeuh commented Jul 24, 2024

b0e1c04#diff-e3ca17fe8a5d858fa29feee3afbe5c72b476f3f94855cc8671e6de59b32f80d2

You deleted some of my code in your latest commit. It's mandatory to make oEmbed works with x.com links.

@oscarotero
Copy link
Copy Markdown
Collaborator

oscarotero commented Jul 24, 2024

@snapeuh Yes, There's a script to update the resources here that fetches automatically the oembed data from https://oembed.com/providers.json.

And X.com is already included (but under publish.x.com, instead of publish.twitter.com)

{
        "provider_name": "X",
        "provider_url": "http://www.x.com/",
        "endpoints": [
            {
                "schemes": [
                    "https://x.com/*",
                    "https://x.com/*/status/*",
                    "https://*.x.com/*/status/*"
                ],
                "url": "https://publish.x.com/oembed"
            }
        ]
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants