Open
Conversation
add tests for the Lookup, ConditionalLookup and Loader Builders
make "type" nullable (should be "attributeCode" by default), remove function "withCapacity" because the capacity is required when instancing those classes anyway
add tests to check if the Capacities throw errors when providing wrong and right configurations, test the builders by providing the capacity's configuration as an array (closer to user-written YAML) to cover more code
…e' into feature/http-client-test-coverage
…works for both Enterprise and Community
…hod_chaining_indentation" => true), remove any mentions of the now defunct "enterprise" option
add more tests to catch exceptions when building the capacities
…est-coverage # Conflicts: # composer.lock # src/Builder/Capacity/Lookup/Get.php # src/Builder/ConditionalLookup.php # src/Builder/Lookup.php # src/Capacity/Extractor/All.php # src/Configuration.php # src/Configuration/Client.php # src/Configuration/Extractor.php # src/Configuration/Loader.php # src/Configuration/Lookup.php # src/Configuration/Search.php # src/Factory/Extractor.php # src/Factory/Loader.php # src/Factory/Lookup.php
provide the builder's capacity in the constructor instead of using a method called "withCapacity()"
attempt to test Factory/Client.php with a HttpClient, remove a try-catch that could never be triggered, raise min MSI to 60%
…est-coverage # Conflicts: # .github/workflows/phpstan-5.yaml # .github/workflows/phpstan-7.yaml # .github/workflows/phpstan-8.yaml # .github/workflows/quality.yaml # composer.json # composer.lock # infection.json.dist # rector.php # src/Builder/AlternativeLookup.php # src/Builder/Capacity/Extractor/All.php # src/Builder/Capacity/Extractor/ListPerPage.php # src/Builder/Capacity/Loader/Upsert.php # src/Builder/Capacity/Lookup/All.php # src/Builder/Capacity/Lookup/ListPerPage.php # src/Builder/Client.php # src/Builder/ConditionalLookup.php # src/Builder/Extractor.php # src/Builder/Loader.php # src/Builder/Lookup.php # src/Capacity/Extractor/All.php # src/Capacity/Extractor/ListPerPage.php # src/Capacity/Lookup/All.php # src/Capacity/Lookup/Download.php # src/Capacity/Lookup/ListPerPage.php # src/Configuration.php # src/Configuration/Extractor.php # src/Configuration/Loader.php # src/Configuration/Lookup.php # src/Factory/Client.php # src/Factory/Extractor.php # src/Factory/Loader.php # src/Factory/Lookup.php # src/Factory/Search.php # tests/functional/Builder/BuilderTestCase.php # tests/functional/Capacity/Extractor/AllTest.php # tests/functional/Capacity/Extractor/ListPerPageTest.php # tests/functional/Capacity/Lookup/AllTest.php # tests/functional/Capacity/Lookup/DownloadTest.php # tests/functional/Capacity/Lookup/ListPerPageTest.php # tests/functional/Configuration/LookupTest.php # tests/functional/Factory/ExtractorTest.php # tests/functional/Factory/LoaderTest.php # tests/functional/Factory/LookupTest.php # tests/functional/Factory/Repository/ExtractorTest.php # tests/functional/Factory/Repository/LoaderTest.php # tests/functional/Factory/Repository/LookupTest.php # tests/functional/Mock/ExceptionBuilder.php # tests/functional/Mock/HttpClientBuilder.php # tests/functional/Mock/RequestMatcher/RequestMatcherBuilder.php # tests/functional/Mock/ResponseBuilder.php # tests/functional/ServiceTest.php
clemzarch
force-pushed
the
feature/http-client-test-coverage
branch
from
6465a63 to
637884f
Compare
[rector] Rector fixes, avoid case where we build "is_null(null)"
clemzarch
force-pushed
the
feature/http-client-test-coverage
branch
from
637884f to
940910b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.