Make options optional again#66
Merged
Merged
Conversation
This was done incorrectly in php-http#65
Contributor
Author
|
@dbu what about this one ? |
dbu
reviewed
Sep 4, 2024
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
oh, absolutely, sorry about that one.
dbu
requested changes
Sep 4, 2024
Contributor
|
thanks for the fix! https://github.com/php-http/multipart-stream-builder/releases/tag/1.4.1 |
|
This change seems to cause static analysis tools like (at least) Psalm to stumble over calls to |
ruudk
added a commit
to ruudk/multipart-stream-builder
that referenced
this pull request
Sep 4, 2024
Otherwise optionals don't work. See php-http#66
Contributor
Author
dbu
added a commit
that referenced
this pull request
Sep 4, 2024
* Unquote array shape field names Otherwise optionals don't work. See #66 * align parameter phpdoc --------- Co-authored-by: David Buchmann <david@liip.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done incorrectly in #65
/cc @dbu