Add Oracle AI Database 26ai BOOLEAN column fetch support#35
Open
sharadraju wants to merge 1 commit intomainfrom
Open
Add Oracle AI Database 26ai BOOLEAN column fetch support#35sharadraju wants to merge 1 commit intomainfrom
sharadraju wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
@shivammathur I am getting some Windows build errors for this PR on the CI pipeline , although the root cause is not clear from the logs. The Linux builds seem to be fine. The code changes are not platform-specific or even that big. Can you please look into it and let me know if I need to change anything here? |
Member
Collaborator
Author
|
Awesome! |
mvorisek
reviewed
Jan 9, 2026
| ["id"]=> | ||
| string(1) "2" | ||
| ["bool_val"]=> | ||
| string(1) "0" |
Collaborator
There was a problem hiding this comment.
Any reason to not return false/true here directly?
Collaborator
Author
sharadraju
force-pushed
the
boolean_support
branch
from
2e5f04c to
a079f62
Compare
sharadraju
force-pushed
the
boolean_support
branch
from
a079f62 to
db9d568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Oracle AI Database 26ai BOOLEAN column fetch support