Fixing incorrect error message when passing null to join/implode's array parameter

[CViniciusSDias]

When passing null to the second parameter of join/implode function, the error message said "string given" instead of "null given". This PR changes the error message to display the correct type.

I also added the test to it in a separate file since the implode1.phpt was huge already and it doesn't follow the recommendation of having _error suffix.

Fixes #12682

[iluuu1994]

I think you misread the error message.

[Girgias]

Related to #11991

[Girgias]

Doing a simple if/else would be better IMHO. You coul keep the == 1 condition for the first case.

However, the issue @iluuu1994 is talking about (without me looking at test failures) is that the errors might reference the wrong variable+type name when providing an invalid type for the 1 parameter version.

[CViniciusSDias]

Doing a simple if/else would be better IMHO. You coul keep the == 1 condition for the first case.

Got it. Just pushed the change.

However, the issue @iluuu1994 is talking about (without me looking at test failures) is that the errors might reference the wrong variable+type name when providing an invalid type for the 1 parameter version.

I'll take a look at the failing tests and see if that's the case.

[CViniciusSDias]

Yes. That would cause implode('') to throw:

implode(): Argument #1 ($separator) must be of type array, string given

So I'll go back to my original approach, ok?

[CViniciusSDias]

If after this change everything is ok, I have one question:

I'd like to merge the implode_ and join_ testcases so we don't have them with different function names. Would that be ok?
And if that's ok, should I do it in a separate PR?

[Girgias]

@iluuu1994 do you think this is fine or should we still split ZPP into two arity cases?

[iluuu1994]

do you think this is fine or should we still split ZPP into two arity cases?

It's fine. I think that only the message may be adjusted.

[iluuu1994]

LGTM otherwise

[CViniciusSDias]

Are there any actions I need to take here or is this PR good? 😁