-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fixed GH-17383 - pdo_firebird: PDOException has wrong code and message since PHP 8.4 #18072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay it makes sense, but do you have a test for this?
cc75f5b
to
dfd424b
Compare
dfd424b
to
eb8d99e
Compare
Finally finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash into a single commit upon merging.
ext/pdo_firebird/tests/gh17383.phpt
Outdated
@@ -0,0 +1,38 @@ | |||
--TEST-- | |||
GH-17383 PDOException has wrong code and message since PHP 8.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH-17383 PDOException has wrong code and message since PHP 8.4 | |
GH-17383 (PDOException has wrong code and message since PHP 8.4) |
Fixes #17383
This is an idea by Christoph :)