Fixed GH-17383 - pdo_firebird: PDOException has wrong code and message since PHP 8.4#18072
Closed
SakiTakamachi wants to merge 9 commits intophp:PHP-8.4from
Closed
Fixed GH-17383 - pdo_firebird: PDOException has wrong code and message since PHP 8.4#18072SakiTakamachi wants to merge 9 commits intophp:PHP-8.4from
SakiTakamachi wants to merge 9 commits intophp:PHP-8.4from
Conversation
ndossche
reviewed
Apr 17, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Okay it makes sense, but do you have a test for this?
SakiTakamachi
force-pushed
the
fix/gh17383
branch
9 times, most recently
from
cc75f5b to
dfd424b
Compare
SakiTakamachi
force-pushed
the
fix/gh17383
branch
from
dfd424b to
eb8d99e
Compare
Member
Author
|
Finally finished. |
ndossche
approved these changes
Apr 18, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Please squash into a single commit upon merging.
| @@ -0,0 +1,38 @@ | |||
| --TEST-- | |||
| GH-17383 PDOException has wrong code and message since PHP 8.4 | |||
Member
There was a problem hiding this comment.
Suggested change
| GH-17383 PDOException has wrong code and message since PHP 8.4 | |
| GH-17383 (PDOException has wrong code and message since PHP 8.4) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17383
This is an idea by Christoph :)