Skip to content

Fixed GH-17383 - pdo_firebird: PDOException has wrong code and message since PHP 8.4 #18072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

SakiTakamachi
Copy link
Member

Fixes #17383

This is an idea by Christoph :)

@SakiTakamachi SakiTakamachi marked this pull request as ready for review March 16, 2025 06:13
@SakiTakamachi SakiTakamachi requested a review from cmb69 March 16, 2025 06:13
@SakiTakamachi SakiTakamachi requested a review from nielsdos April 17, 2025 02:01
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it makes sense, but do you have a test for this?

@SakiTakamachi SakiTakamachi requested a review from TimWolla as a code owner April 18, 2025 02:53
@SakiTakamachi SakiTakamachi force-pushed the fix/gh17383 branch 9 times, most recently from cc75f5b to dfd424b Compare April 18, 2025 08:00
@SakiTakamachi
Copy link
Member Author

Finally finished.
I’ve added the test.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into a single commit upon merging.

@@ -0,0 +1,38 @@
--TEST--
GH-17383 PDOException has wrong code and message since PHP 8.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GH-17383 PDOException has wrong code and message since PHP 8.4
GH-17383 (PDOException has wrong code and message since PHP 8.4)

SakiTakamachi added a commit that referenced this pull request Apr 19, 2025
* PHP-8.4:
  Fixed GH-17383 - pdo_firebird: PDOException has wrong code and message since PHP 8.4 (#18072)
@SakiTakamachi SakiTakamachi deleted the fix/gh17383 branch April 23, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants