ext/ffi: Various minor refactorings #18176
Merged
+140
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Mar 29, 2025
dstogov
reviewed
Mar 31, 2025
ext/ffi/ffi.c
Outdated
| if (ZSTR_LEN(name) == sizeof("new") -1 | ||
| && (ZSTR_VAL(name)[0] == 'n' || ZSTR_VAL(name)[0] == 'N') | ||
| && (ZSTR_VAL(name)[1] == 'e' || ZSTR_VAL(name)[1] == 'E') | ||
| && (ZSTR_VAL(name)[2] == 'w' || ZSTR_VAL(name)[2] == 'W')) { | ||
| if (zend_string_equals_literal_ci(name, "new")) { |
There was a problem hiding this comment.
zend_string_equals_literal_ci() is going to be slower. I would prefer to revert this.
|
Dropped the zend_strings_equals commit and added another commit to attach your explanation to it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually.