-
Notifications
You must be signed in to change notification settings - Fork 7.8k
throw on null bytes / resolve GH-13952 #18320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix a corruption issue where PDO::quote for SQLite would silently truncate strings with null bytes in them, by throwing. resolve phpGH-13952 close phpGH-13972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for @SakiTakamachi 's final approval, but this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked for a suitable SQL state, but couldn’t find one that fits well, so the current code seems to be the best option, thanks!
edit:
I’m out right now, but if it hasn’t been merged by the time I get back, I’ll merge it then :)
maybe sqlstate quoting ansi SQL:2011 draft at https://web.archive.org/web/20230525220603if_/https://www.wiscorp.com/sql20nn.zip
or maybe 39000
|
In my view, none of them seem appropriate. Also, I’m not sure whether this can be referred to as an “external routine.” |
Merged :) |
fix a corruption issue where PDO::quote for SQLite would silently truncate strings with null bytes in them,
by throwing.
resolve GH-13952
close GH-13972