Don't evaluate GMP comparison multiple times #18321
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZEND_THREEWAY_COMPARE evaluates its operands multiple times.
mvorisek
reviewed
Apr 14, 2025
| @@ -480,7 +480,8 @@ static int gmp_compare(zval *op1, zval *op2) /* {{{ */ | |||
| return ZEND_UNCOMPARABLE; | |||
| } | |||
|
|
|||
| return ZEND_THREEWAY_COMPARE(mpz_cmp(gmp_op1, gmp_op2), 0); | |||
| int ret = mpz_cmp(gmp_op1, gmp_op2); /* avoid multiple evaluations */ | |||
| return ZEND_THREEWAY_COMPARE(ret, 0); | |||
There was a problem hiding this comment.
is it somehow possible to put this into the macro itself?
There was a problem hiding this comment.
Not without relying on non-portable GCC extensions.
Girgias
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZEND_THREEWAY_COMPARE evaluates its operands multiple times.