ext/zlib: Refactor tests #18887
Open
ext/zlib: Refactor tests #18887
+171
−698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
zlib-tests
branch
2 times, most recently
from
da342a3 to
d27b117
Compare
- Move data into a subfolder - Remove ZPP tests - Fix various bugs within tests - Simplify some
nielsdos
approved these changes
Jun 21, 2025
| @@ -45,7 +45,7 @@ function test($case) { | |||
| // The gzdecode() function applied to the corrupted compressed data always | |||
| // detects the error: | |||
| // --> gzdecode(): PHP Fatal error: Uncaught ErrorException: gzdecode(): data error in ... | |||
| echo "gzdecode(): ", rawurldecode(gzdecode($compressed)), "\n"; | |||
| echo "gzdecode(): ", rawurldecode((string) gzdecode($compressed)), "\n"; | |||
There was a problem hiding this comment.
Because gzdecode() can return false, and I didn't really want to bother figuring out why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #18879