Skip to content

make it installable in web sub directory #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

peterdd
Copy link
Contributor

@peterdd peterdd commented Sep 10, 2021

The global $basedir configuration is currently not used across the sources.

This PR fixes it by using the base href tag and fixing the links.

@peterdd
Copy link
Contributor Author

peterdd commented Oct 18, 2021

There is one thing that may be annoying: When using the base-tag, relative links like <a href="#section3">Section 3 Title</a> a request to server is done instead just jumping to the position of the target id in the document without additional http request.

Wouldn't this make the base tag quite useless?

Need to research when and why this odd behavior was added/changed in HTML4/5 standards ..

@nikic
Copy link
Member

nikic commented Oct 21, 2021

Not sure it's worthwhile to support this. Nowadays a root URL is just a php -S localhost:8000 -t www away.

@peterdd
Copy link
Contributor Author

peterdd commented Oct 21, 2021

I am just testing the php.net programs with apache http server in vagrant boxes, sister programs like https://pear.php.net/bugs/ use also a web sub directory.

And there is this configuration available in the sources, so made it somehow work.

So that was the motivation.

@derickr
Copy link
Member

derickr commented Jul 31, 2024

bugs.php.net is no longer really used, and hence, we're sunsetting it. Due to that, I don't think it makes sense to merge this patch, which also has conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants