-
Notifications
You must be signed in to change notification settings - Fork 63
make it installable in web sub directory #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
using base href tag and converting links from absolute '/' to using the base href.
There is one thing that may be annoying: When using the base-tag, relative links like Wouldn't this make the base tag quite useless? Need to research when and why this odd behavior was added/changed in HTML4/5 standards .. |
Not sure it's worthwhile to support this. Nowadays a root URL is just a |
I am just testing the php.net programs with apache http server in vagrant boxes, sister programs like https://pear.php.net/bugs/ use also a web sub directory. And there is this configuration available in the sources, so made it somehow work. So that was the motivation. |
bugs.php.net is no longer really used, and hence, we're sunsetting it. Due to that, I don't think it makes sense to merge this patch, which also has conflicts. |
The global $basedir configuration is currently not used across the sources.
This PR fixes it by using the base href tag and fixing the links.