Skip to content

remove apib file #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2025
Merged

remove apib file #142

merged 2 commits into from
Jan 18, 2025

Conversation

TatevikGr
Copy link
Contributor

Summary

remove incorrect api demo file

Thanks for contributing to phpList!

@TatevikGr TatevikGr requested a review from michield January 15, 2025 17:24
@michield
Copy link
Member

You're also removing the api-docs workflow. Don't we want to keep that?

@michield
Copy link
Member

Also, instead of removing it, I think it may be useful, we just need to fix things that are incorrect in it?

Not sure. Maybe we should start from scratch?

@TatevikGr
Copy link
Contributor Author

Also, instead of removing it, I think it may be useful, we just need to fix things that are incorrect in it?

Not sure. Maybe we should start from scratch?

We have swagger as api documentation

If we will need workflow file in the future it will still be in git history (at the mement I do not see where it can be used if we are removing apib file)

Copy link
Member

@michield michield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that's fine then. Yes, let's just have Swagger for the docs

@TatevikGr TatevikGr merged commit d93647d into main Jan 18, 2025
4 checks passed
@TatevikGr TatevikGr deleted the remove-apib branch January 18, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants