[FEATURE] Add the Symfony console and the public web/ directory #28
Conversation
Classes/Composer/ScriptHandler.php
Outdated
| @@ -0,0 +1,44 @@ | |||
| <?php | |||
There was a problem hiding this comment.
This script appears to be a duplicate from the base-distribution package (minus unit tests) -- will it be removed from there?
There was a problem hiding this comment.
No, this is not that easy. Currently, the script is expected to be in the root package only (at least when it is called), i.e. in the base distributions for the application installation, and in rest-api when testing the rest-api without the base-distribution. It currently relies on this fact to determine the root package path.
I'll use a different approach instead: I'm currently working on a function for determining the application root path. I'll then move the Composer ScriptHandler to the core package and use that from base-distribution, rest-api and web-frontend.
There was a problem hiding this comment.
Hence marking this PR as blocked. (The base-distribution PR is not blocked, though.)
oliverklee
force-pushed
the
feature/console
branch
from
a4f98e6 to
d11a22a
Compare
|
This PR now is using the corresponding core functions. I've also added automatic creation of the web/ folder (which just like bin/ is also for development purposes only). Currently, this build failing locally for me in the Controller integration tests due to a bug in the core concerning the application root directory. I'll look into it. |
Note: The console and the web directory will only be added if this project is the project root (i.e., usually when developing the package), not if is a requirement of the base-distribution package (or any other package).
oliverklee
force-pushed
the
feature/console
branch
from
d11a22a to
582e084
Compare
oliverklee
changed the title
|
This PR fixes the problem: phpList/core#144 |
Note: The console will only be added if this project is the project root
(i.e., usually when developing the package), not if is a requirement of
the base-distribution package (or any other package).