support deprecated magic __toString() in echo statement #37
Conversation
tests/Rules/Deprecations/data/echo-deprecated-magic-method-tostring.php
Outdated
Show resolved
Hide resolved
| if (!$methodReflection->isDeprecated()->yes()) { | ||
| continue; | ||
| } | ||
|
|
||
| $description = $methodReflection->getDeprecatedDescription(); | ||
| if ($description === null) { | ||
| $messages[] = sprintf( | ||
| 'Call to deprecated method %s() of class %s.', | ||
| $methodReflection->getName(), | ||
| $methodReflection->getDeclaringClass()->getName() | ||
| ); | ||
| } else { | ||
| $messages[] = sprintf( | ||
| "Call to deprecated method %s() of class %s:\n%s", | ||
| $methodReflection->getName(), | ||
| $methodReflection->getDeclaringClass()->getName(), | ||
| $description | ||
| ); | ||
| } |
There was a problem hiding this comment.
most of this code is inspired by CallToDeprecatedMethodRule
tests/Rules/Deprecations/data/echo-deprecated-magic-method-tostring.php
Outdated
Show resolved
Hide resolved
|
Hi, this is rather incomplete and does not have rules for other situations. What I recommend in your situation:
|
|
Thx for your feedback. I am not sure how I should take it. I am aware there are a lot of more things to take care of, but just want to get in contact early, since the very basic case which is important to me is already covered. Was your suggestion about how I should proceed to get this rule into shape so you might consider merging it, or was your intention to give me a hint of how I should handle a possible deprecated Thanks again |
|
I want ahead and added more coverage for more complex expressions. In case someone knows a expression I am missing feel free to sent me an example. |
| * @param Scope $scope | ||
| * @param string[] $messages | ||
| */ | ||
| private function deepCheckExpr(Node\Expr $expr, Scope $scope, array &$messages): void |
There was a problem hiding this comment.
As a followup step, I would extract this logic into a helper and add a separate rule for Print.
Additionally a Rule could be added for the string-concat case
…e with bleeding edge switch
|
hey ondrey, thx again for your feedback. I tried to incorporate what I have understood so far. I have extracted a new does this look good to you? |
with this change phpstan is able to detect cases, where object values are used in
echostatements and implicitly call a magic and deprecated__toStringmethod.In case this new rule gets accepted, I would be willing to implement the same for the
printstatement.refs phpstan/phpstan#4899