symfony uuid type descriptor#639
Closed
alcohol wants to merge 1 commit intophpstan:2.0.xfrom
Closed
Conversation
ea7e7fb to
9540f53
Compare
Member
|
No idea why it's failing. Try removing the dependencies from require-dev you just added. |
Author
|
I think it's failing cause a test uses a class from |
Member
|
Also - the descriptor has to be registered, and also - add a test that shows what problem it's solving. Descriptors are already being tested in EntityColumnRuleTest. |
Author
|
That fixed most existing failures; except for deprecations on the very latest version. |
Author
|
@ondrejmirtes can I add the test inside the same class? Am wondering since both Ramsey and Symfony register a 'uuid' type and the one for Ramsey is already tested/used in that class. |
Member
|
Yeah, sure. |
Author
|
Yeah that didn't work; the error is for the Ramsey uuid type then, not Symfony. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #637