Add test for phpstan issue 7396 #1442
Conversation
mvorisek
force-pushed
the
test_method_type_specify
branch
2 times, most recently
from
f8326f6 to
eee8782
Compare
| $m = random_int(0, 1) === 0 ? new Model() : new class() extends Model implements Iface {}; | ||
| assertType('Bug7385\Model', $m); | ||
| $m->assertHasIface(); | ||
| assertType('Bug7385\Iface&Bug7385\Model', $m); |
There was a problem hiding this comment.
@ondrejmirtes this assertion is not passing, do you know why?
Bug7385MethodTypeSpecifyingExtension::specifyTypes()is correctly reached and$typeis (the expected)Bug7385\Iface&Bug7385\Model- I am not completely sure what
TypeSpecifierContext::createXxx()is used for or if I should useTypeSpecifierContext::createTrue(), but I tried it. - I also tried to to set
$overwriteparam totruein$this->typeSpecifier->create()factory method, but it seems the$mtype is stillBug7385\Modelas if theMethodTypeSpecifyingExtensionresult is completely ignored
There was a problem hiding this comment.
@ondrejmirtes can you please take a look on this issue?
There was a problem hiding this comment.
There's 343 open bug reports (https://github.com/phpstan/phpstan/labels/bug) and 323 feature requests (https://github.com/phpstan/phpstan/labels/feature-request). Your issue isn't anything urgent to warrant immediate attention - it's not anything special and doesn't stand out from other 666 open issues.
This PR doesn't even have an associated issue - I closed #7385 because there wasn't anything about type-specifying extensions in the description.
There might even be an open issue about "type-specifying extension doesn't allow me to change the type of the object the method is called on", I'm not sure.
Anyway, if you're already this far, you can take one more step and debug where it actually gets lost, and fix it.
There was a problem hiding this comment.
yes, there is phpstan/phpstan#7396 issue I opened later after a short discussion about an implicit support in phpstan/phpstan#7385
mvorisek
changed the title
mvorisek
force-pushed
the
test_method_type_specify
branch
from
5e86e33 to
92c4220
Compare
This reverts commit e89b50a2b03e2f635eb6b2a2e0c0cf61a54692f8.
mvorisek
force-pushed
the
test_method_type_specify
branch
from
92c4220 to
d90bc0a
Compare
repro for phpstan/phpstan#7396