Revert "Make array access on possible false tolerant with isset"

.devcontainer/library-scripts/node-debian.sh

@@ -18,7 +18,7 @@ if [ "$(id -u)" -ne 0 ]; then
     exit 1
 fi
 
-# Treat a user name of "none" or non-existant user as root
+# Treat a user name of "none" or non-existent user as root
 if [ "${USERNAME}" = "none" ] || ! id -u ${USERNAME} > /dev/null 2>&1; then
     USERNAME=root
 fi

.github/renovate.json

@@ -3,8 +3,10 @@
     "config:base",
     "schedule:weekly"
   ],
+  "dependencyDashboard": true,
   "rangeStrategy": "update-lockfile",
   "rebaseWhen": "conflicted",
+  "baseBranches": ["1.11.x"],
   "packageRules": [
     {
       "matchPackagePatterns": ["*"],
@@ -13,7 +15,7 @@
     {
       "matchPaths": ["+(composer.json)"],
       "enabled": true,
-      "groupName": "root-composer"
+      "matchBaseBranches": ["1.11.x"]
     },
     {
       "matchPaths": ["build-cs/**"],
@@ -25,6 +27,16 @@
       "enabled": true,
       "groupName": "apigen"
     },
+    {
+	  "matchPaths": ["issue-bot/**"],
+	  "enabled": true,
+	  "groupName": "issue-bot"
+    },
+    {
+      "matchPaths": ["changelog-generator/**"],
+      "enabled": true,
+      "groupName": "changelog-generator"
+    },
     {
       "matchPaths": ["compiler/**"],
       "enabled": true,

.github/workflows/apiref.yml

@@ -3,9 +3,10 @@
 name: "API Reference"
 
 on:
+  workflow_dispatch:
   push:
     branches:
-      - "1.9.x"
+      - "1.11.x"
     paths:
       - 'src/**'
       - 'composer.lock'
@@ -25,7 +26,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: "Install PHP"
         uses: "shivammathur/setup-php@v2"
@@ -44,7 +45,7 @@ jobs:
         run: "apigen/vendor/bin/apigen -c apigen/apigen.neon --output docs -- src vendor/nikic/php-parser vendor/ondrejmirtes/better-reflection vendor/phpstan/phpdoc-parser"
 
       - name: "Upload docs"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: docs
           path: docs
@@ -57,12 +58,12 @@ jobs:
     runs-on: "ubuntu-latest"
     steps:
       - name: "Install Node"
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: "16"
 
       - name: "Download docs"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: docs
           path: docs
@@ -88,7 +89,7 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ secrets.APIREF_AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.APIREF_AWS_SECRET_ACCESS_KEY }}
 
-      - uses: peter-evans/repository-dispatch@v2
+      - uses: peter-evans/repository-dispatch@v3
         with:
           token: ${{ secrets.PHPSTAN_BOT_TOKEN }}
           repository: "phpstan/phpstan"

.github/workflows/backward-compatibility.yml

@@ -6,13 +6,13 @@ on:
   pull_request:
   push:
     branches:
-      - "1.8.x"
+      - "1.11.x"
     paths:
       - 'src/**'
       - '.github/workflows/backward-compatibility.yml'
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.11.x-dev"
 
 concurrency:
   group: bc-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches
@@ -27,7 +27,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -44,7 +44,7 @@ jobs:
         run: |
           composer global config minimum-stability dev
           composer global config prefer-stable true
-          composer global require --dev ondrejmirtes/backward-compatibility-check:^7.3.0
+          composer global require --dev ondrejmirtes/backward-compatibility-check:^7.3.0.1
 
       - name: "Check"
         run: "$(composer global config bin-dir --absolute)/roave-backward-compatibility-check"

.github/workflows/build-issue-bot.yml

@@ -0,0 +1,57 @@
+# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
+
+name: "Build Issue Bot"
+
+on:
+  pull_request:
+    paths:
+      - 'issue-bot/**'
+      - '.github/workflows/build-issue-bot.yml'
+  push:
+    branches:
+      - "1.11.x"
+    paths:
+      - 'issue-bot/**'
+      - '.github/workflows/build-issue-bot.yml'
+
+env:
+  COMPOSER_ROOT_VERSION: "1.11.x-dev"
+
+concurrency:
+  group: build-issue-bot-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches
+  cancel-in-progress: true
+
+jobs:
+  build-issue-bot:
+    name: "Build Issue Bot"
+
+    runs-on: "ubuntu-latest"
+    timeout-minutes: 60
+
+    strategy:
+      fail-fast: false
+      matrix:
+        script:
+          - "../bin/phpstan"
+          - "vendor/bin/phpunit"
+
+    steps:
+      - name: "Checkout"
+        uses: actions/checkout@v4
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "8.3"
+
+      - name: "Install dependencies"
+        run: "composer install --no-interaction --no-progress"
+
+      - name: "Install Issue Bot dependencies"
+        working-directory: "issue-bot"
+        run: "composer install --no-interaction --no-progress"
+
+      - name: "Tests"
+        working-directory: "issue-bot"
+        run: ${{ matrix.script }}

.github/workflows/changelog-generator.yml

@@ -9,11 +9,14 @@ on:
       - '.github/workflows/changelog-generator.yml'
   push:
     branches:
-      - "1.8.x"
+      - "1.11.x"
     paths:
       - 'changelog-generator/**'
       - '.github/workflows/changelog-generator.yml'
 
+env:
+  COMPOSER_ROOT_VERSION: "1.11.x-dev"
+
 concurrency:
   group: changelog-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches
   cancel-in-progress: true
@@ -27,7 +30,7 @@ jobs:
 
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: "Install PHP"
         uses: "shivammathur/setup-php@v2"

.github/workflows/checksum-phar.yml

@@ -0,0 +1,127 @@
+# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
+
+# This workflow checks that PHAR checksum changes only when it's supposed to
+# It should stay the same when the PHAR contents do not change
+
+name: "Check PHAR checksum"
+
+on:
+  pull_request:
+    paths:
+      - 'compiler/**'
+      - '.github/workflows/checksum-phar.yml'
+  push:
+    branches:
+      - "1.11.x"
+    paths:
+      - 'compiler/**'
+      - '.github/workflows/checksum-phar.yml'
+
+env:
+  COMPOSER_ROOT_VERSION: "1.11.x-dev"
+
+concurrency:
+  group: checksum-phar-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches
+  cancel-in-progress: true
+
+jobs:
+  check-phar-checksum:
+    name: "Check PHAR checksum"
+
+    runs-on: "ubuntu-latest"
+    timeout-minutes: 60
+
+    steps:
+      - name: "Checkout phpstan-dist"
+        uses: actions/checkout@v4
+        with:
+          repository: phpstan/phpstan
+          path: phpstan-dist
+          ref: 1.11.x
+
+      - name: "Get info"
+        id: info
+        working-directory: phpstan-dist
+        run: |
+          echo "checksum=$(head -n 1 .phar-checksum)" >> $GITHUB_OUTPUT
+          echo "commit=$(tail -n 1 .phar-checksum)" >> $GITHUB_OUTPUT
+
+      - name: "Delete phpstan-dist"
+        run: "rm -r phpstan-dist"
+
+      - name: "Checkout"
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ steps.info.outputs.commit }}
+
+      - name: "Checkout latest PHAR compiler"
+        uses: actions/checkout@v4
+        with:
+          path: phpstan-src
+          ref: ${{ github.sha }}
+
+      - name: "Delete old compiler"
+        run: "rm -r compiler"
+
+      - name: "Move new compiler"
+        run: "mv phpstan-src/compiler/ ."
+
+      - name: "Delete phpstan-src"
+        run: "rm -r phpstan-src"
+
+      - name: "Change and commit README.md"
+        run: |
+          echo Testing > README.md
+          git config --global user.name "phpstan-bot"
+          git config --global user.email "[email protected]"
+          git commit -a -m 'Changed README'
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "8.1"
+          extensions: mbstring, intl
+
+      - name: "Install dependencies"
+        run: "composer install --no-interaction --no-progress"
+
+      - name: "Install compiler dependencies"
+        run: "composer install --no-interaction --no-progress --working-dir=compiler"
+
+        # same steps as in phar.yml
+
+      - name: "Prepare for PHAR compilation"
+        working-directory: "compiler"
+        run: "php bin/prepare"
+
+      - name: "Set autoloader suffix"
+        run: "composer config autoloader-suffix PHPStanChecksum"
+
+      - name: "Composer dump"
+        run: "composer install --no-interaction --no-progress"
+        env:
+          COMPOSER_ROOT_VERSION: "1.11.x-dev"
+
+      - name: "Compile PHAR for checksum"
+        working-directory: "compiler/build"
+        run: "php box.phar compile --no-parallel"
+        env:
+          PHAR_CHECKSUM: "1"
+          COMPOSER_ROOT_VERSION: "1.11.x-dev"
+
+      - name: "Re-sign PHAR"
+        run: "php compiler/build/resign.php tmp/phpstan.phar"
+
+      - name: "Unset autoloader suffix"
+        run: "composer config autoloader-suffix --unset"
+
+      - name: "Save checksum"
+        id: "new_checksum"
+        run: echo "md5=$(md5sum tmp/phpstan.phar | cut -d' ' -f1)" >> $GITHUB_OUTPUT
+
+      - name: "Assert checksum"
+        run: |
+          checksum=${{ steps.info.outputs.checksum }}
+          new_checksum=${{ steps.new_checksum.outputs.md5 }}
+          [[ "$checksum" == "$new_checksum" ]];

.github/workflows/create-tag.yml

@@ -21,10 +21,10 @@ jobs:
     runs-on: "ubuntu-latest"
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
-          token: ${{ secrets.PAT }}
+          token: ${{ secrets.PHPSTAN_BOT_TOKEN }}
 
       - name: 'Get Previous tag'
         id: previoustag