feat: add options to report ignores without identifiers or comments #3976
+222
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-qtlvsunynsrq
branch
from
94bcb68 to
47d8329
Compare
|
CI failures look to be unrelated |
calebdw
changed the title
calebdw
force-pushed
the
calebdw/push-qtlvsunynsrq
branch
from
108c052 to
384c8af
Compare
calebdw
force-pushed
the
calebdw/push-qtlvsunynsrq
branch
from
384c8af to
0475ff1
Compare
|
Thanks for providing this & also picking up the case for no comments 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Closes phpstan/phpstan#11340
This PR adds the following two options (false by default):
reportIgnoresWithoutIdentifiers: reports@phpstan-ignore-lineand@phpstan-ignore-next-lineusagesreportIgnoresWithoutComments: reports@phpstan-ignoreusages without commentsThanks!