[ReturnTypeExtension] add test case for narrow typed json_decode #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Feb 4, 2022
TomasVotruba
force-pushed
the
tv-json-decode-narrow-type
branch
from
96ca0b7 to
f682afa
Compare
ondrejmirtes
requested changes
Feb 6, 2022
tests/PHPStan/Analyser/data/json-decode/narrow_type_with_force_array.php
Show resolved
Hide resolved
tests/PHPStan/Analyser/data/json-decode/narrow_type_with_force_array.php
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-json-decode-narrow-type
branch
3 times, most recently
from
5547fb8 to
55cc2d4
Compare
|
I'm working on the static errors... |
ondrejmirtes
force-pushed
the
1.5.x
branch
3 times, most recently
from
ddd20b4 to
95d480b
Compare
|
Feel free to open a new PR if you ever decide to work on this again 👍 Thanks. |
|
It's ready from my side 👍 I'm actually waiting for feedback last 2 months:
|
|
It is not - there were conflicts and build failures. |
ondrejmirtes
requested changes
Mar 24, 2022
|
I'm on it 👍 |
TomasVotruba
force-pushed
the
tv-json-decode-narrow-type
branch
3 times, most recently
from
2e46788 to
aafd2a3
Compare
|
I've rebased. Tests, PHPStan and coding standards are passing localy. Seems GitHub Actions are crashing now because cache is stuck: https://github.com/phpstan/phpstan-src/runs/5677735280?check_suite_focus=true I'll check it today/tomorrow |
TomasVotruba
force-pushed
the
tv-json-decode-narrow-type
branch
5 times, most recently
from
1cac3b6 to
834eff1
Compare
ondrejmirtes
force-pushed
the
tv-json-decode-narrow-type
branch
from
834eff1 to
2aa201a
Compare
|
CI is passing 👍 |
herndlm
force-pushed
the
tv-json-decode-narrow-type
branch
from
b8357ff to
961f9c2
Compare
…e from contssant string value
Co-authored-by: Martin Herndl <[email protected]>
Co-authored-by: Martin Herndl <[email protected]>
ondrejmirtes
force-pushed
the
tv-json-decode-narrow-type
branch
from
961f9c2 to
7d306fb
Compare
ondrejmirtes
approved these changes
May 3, 2022
|
Thank you! |
|
👍 @herndlm Thank you for finishing 👏 |
|
Nice, thank you too. I was waiting for this getting merged, have a tiny follow-up idea :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/phpstan/phpstan-nette/pull/89/files for
json_decode()Any feedback appreciated 👍
How to test?
vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php --filter "json"