Fix price label precision as MktPair.price_tick_digits
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was only really borked for higher-precision but lower priced assets (like TLOS or peeneez) which have a `MktPair.price_tick_digits >= 2`. The issue was using the wrong attr, the `size_tick_digits`..
guilledk
approved these changes
May 31, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hot fix after #489 that wasn't caught (since we don't have UI tests yet..) 😂
Was only really borked for higher-precision but lower priced assets (like TLOS or peeneez) which have a
MktPair.price_tick_digits >= 2.The issue was using the wrong attr, the
size_tick_digits..