Skip to content

Conversation

mfdebian
Copy link
Contributor

@mfdebian mfdebian commented Jul 1, 2025

I'll start with this minor changes and build from here @UlisesGascon @bjohansebas tell me if you think this is the correct approach or not.

For now I'll leave #203 open

@bjohansebas
Copy link
Member

Hey @mfdebian, thanks for your interest in contributing to this package. The recommended and best approach is always to open separate PRs, since a single change can block the entire PR or make the review process complicated if it turns into a huge PR

@mfdebian mfdebian mentioned this pull request Jul 1, 2025
6 tasks
@mfdebian
Copy link
Contributor Author

mfdebian commented Jul 1, 2025

Thank you @bjohansebas! Should I rename this PR and just use it to merge the cherry-picked commits?

@bjohansebas
Copy link
Member

Should I rename this PR and just use it to merge the cherry-picked commits?

Yes, that’s the best. Any other changes you want to make should go in separate and dedicated PRs.

@mfdebian mfdebian changed the title Release v4.3.0 proposal chore(deps): drop support for Express 2.x and use uid-safe for async helpers tracking Jul 1, 2025
@mfdebian
Copy link
Contributor Author

mfdebian commented Jul 1, 2025

Done, thank you @bjohansebas!

@mfdebian mfdebian marked this pull request as ready for review July 1, 2025 01:12
@bjohansebas
Copy link
Member

I'm curious as to why those commits are being brought in, given that they are breaking changes and, according to SemVer, they should be released in a new major version

@mfdebian
Copy link
Contributor Author

Yeah you're right, sorry, I misunderstood Ulises comments on #203 , the idea is to prepare a v5.0 release and I'm trying to help on that. Maybe we can move this PR to point to a v5.0 branch and then start merging commits there and once we're comfortable we can rebase v5.0 to master/main with a proper release, would you be ok with that?

Sorry I took so long to respond/take action, I was on call for the FIFA Club World Cup and it ended just now so now I can take on this 🚀

Let me know your thoughts! And thank you 🙌 !

@bjohansebas
Copy link
Member

Take a look at the process for how releases work within express. while it's focused solely on express, it's the same way releases are handled at the project level (i already have a PR updating it expressjs/discussions#387 to make this a global process, but it works the same). This process will be carried out by the captain of this package.

The changes from this PR are already where they need to be, which is the 5.0 branch, so there’s no need to change the target branch as you suggested. I think the next steps you can take are to open PRs for the features you want to add, update support for the latest Node.js versions (both on master and the 5.0 branch), remove support for older versions, etc. Please keep each change in separate PRs.

@UlisesGascon UlisesGascon changed the base branch from master to 5.0 October 6, 2025 19:08
@UlisesGascon UlisesGascon added the v5 label Oct 6, 2025
@UlisesGascon UlisesGascon self-assigned this Oct 6, 2025
@UlisesGascon
Copy link
Member

My bad on the work definition, here is a better approach (I hope) as now I created a clean and updated version of the branch 5.0.

Some ideas:

  • Can you create separated PR for each commit in this PR?
  • Can you create an issue for tracking 5.0 work using your comment in this PR as a baseline (Release 5.0 #203 (comment))?

... wdyt @mfdebian ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants