Skip to content

Conversation

@inimaz
Copy link

@inimaz inimaz commented Jul 16, 2025

Goal is to update the dependencies so they are up to date and do not have any vulnerabilities.

It is my first time committing to this repo, please do tell me if there is some other procedure I should follow to merge it.

Resolves #6

@UlisesGascon UlisesGascon self-assigned this Jul 24, 2025
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inimaz for this work! ❤️

As we discussed in Slack, let's see if we can adapt #4 to Node@23 and Node@24 to check that we are not introducing any breaking change.

Also in this PR we need to update the HISTORY.md with the relevant changelog changes :)

@inimaz
Copy link
Author

inimaz commented Jul 24, 2025

Workflow added from #4 as requested @UlisesGascon 🚀 , could you approve the run of the job? Thanks!

HISTORY.md Outdated
Comment on lines 5 to 8
- devdeps: eslint@^9.31.0
- devdeps: [email protected]
- devdeps: eslint-plugin-markdown@^5.1.0
- devdeps: mocha@^11.7.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- devdeps: eslint@^9.31.0
- devdeps: [email protected]
- devdeps: eslint-plugin-markdown@^5.1.0
- devdeps: mocha@^11.7.

In the History we focus only in prod ones 👍

HISTORY.md Outdated
- deps: [email protected]

* deps: [email protected]
# 1.3.3 / 2016-11-14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change the headers, we used this legacy format as some people are scrapping this info

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch sorry for this, it was my local prettier

shell: bash
run: sudo apt-get -y install lcov
- name: Collect coverage reports
uses: actions/download-artifact@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4

I think that this will solve the CI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update http-errors to update depd to remove eval()

2 participants