WIP on threadpool impl of query_namespaces #405
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I need a non-async interface providing a similar functionality as the
query_namespaces
currently implemented inGRPCIndexAsyncio
.Solution
Background info:
multiprocessing
ThreadPool is currently setup during the instantiation ofIndex
. The constructor takes a param for number ofpool_threads
with a default value of 1.async_req=True
, the underlying (generated from openapi spec) code will execute the request usingpool.apply_async
. The result of these calls is anApplyResult[QueryResult]
. To get the results, from these we call.get()
on theApplyResult
.New
query_namespaces
onIndex
:query
withasync_req=True
ApplyResults
into a results arrayQueryResultsAggregator
, recently implemented and tested in [Feat] asyncio for grpc data interactions #398Todo:
Usage
Dev build for manual testing
pip install pinecone==6.0.0.dev3
Type of Change
Test Plan
Describe specific steps for validating this change.