Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Oct 16, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Oct 16, 2025
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2025
@hfxsd hfxsd requested review from MyonKeminta and yahonda October 16, 2025 06:48
@hfxsd hfxsd added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Oct 16, 2025
@hfxsd hfxsd requested a review from lilin90 October 16, 2025 06:49
@yahonda
Copy link
Member

yahonda commented Oct 16, 2025

While I need to use some translator to review this document, this statement also does not look like valid anymore

为了降低应用改造难度,TiDB 提供了数据库内部自动重试机制。
(To reduce the difficulty of application migration, TiDB provides an internal automatic retry mechanism.)

Since automatic retry of transactions is disabled by default and it is not recommended anymore.
https://docs.pingcap.com/tidb/stable/transaction-isolation-levels/

Starting from TiDB v3.0, the automatic retry of transactions is disabled by default. It is not recommended to enable the automatic retry because it might break the transaction isolation level. Refer to Transaction Retry for details.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-16 09:23:54.172920285 +0000 UTC m=+345340.250172835: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Oct 16, 2025

@yahonda Thanks for the comment. I added a note to the automatic retry section. You can refer to the English PR pingcap/docs#21927

@lilin90
Copy link
Member

lilin90 commented Oct 17, 2025

New updates LGTM.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2025

@MyonKeminta: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Oct 17, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Oct 17, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 17, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4ef8d7d into pingcap:master Oct 17, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #21010.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants