Skip to content

Replace node number with node count#20549

Closed
yahonda wants to merge 1 commit intopingcap:masterfrom
yahonda:replace_node_number_with_node_count
Closed

Replace node number with node count#20549
yahonda wants to merge 1 commit intopingcap:masterfrom
yahonda:replace_node_number_with_node_count

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented Mar 17, 2025

What is changed, added or deleted? (Required)

The current "node number" refers to the specific identification or label given to each instance. "node count" should refers to the quantity or count of instances, that is needed here. I think "the number of TiDB/TiFlash nodes" are fine.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2025
Although TiKV is mainly used for data storage, the performance of the TiKV node also varies depending on different workloads. Therefore, when planning the number of TiKV nodes, you need to estimate it according to both your [**data volume**](#estimate-tikv-node-number-according-to-data-volume) and [expected performance](#estimate-tikv-node-number-according-to-expected-performance), and then take the larger of the two estimates as the recommended node count.

#### Estimate TiKV node number according to data volume
#### Estimate TiKV node nucountmber according to data volume
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Estimate TiKV node nucountmber according to data volume
#### Estimate TiKV node count according to data volume

@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 11, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Apr 11, 2025

PRs for TiDB Cloud should be created based on the v8.1 branch instead of master. Can you change it to the v8.1 branch? Thanks.

@yahonda yahonda changed the base branch from master to release-8.1 April 11, 2025 08:52
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2025
@yahonda yahonda changed the base branch from release-8.1 to master April 11, 2025 08:53
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2025
@yahonda
Copy link
Copy Markdown
Member Author

yahonda commented Apr 11, 2025

PRs for TiDB Cloud should be created based on the v8.1 branch instead of master. Can you change it to the v8.1 branch? Thanks.

Just changing the base branch release-8.1 makes a lot of unrelated commits. I will create another pull request.

@yahonda yahonda closed this Apr 11, 2025
@yahonda yahonda mentioned this pull request Apr 21, 2025
15 tasks
@yahonda
Copy link
Copy Markdown
Member Author

yahonda commented Apr 21, 2025

Just changing the base branch release-8.1 makes a lot of unrelated commits. I will create another pull request.

Opened #20811 for the release-8.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants