Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system variable back for tidb_enable_point_get_plan_cache. #20679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 31, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

after fix of pingcap/tidb#60272, we add tidb_enable_point_get_cache back, so we just add the variable document back

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

.
Signed-off-by: AilinKid <[email protected]>
Copy link

ti-chi-bot bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2025
.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 31, 2025
Copy link

ti-chi-bot bot commented Mar 31, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-31 09:45:28.956953773 +0000 UTC m=+1472022.641189870: ☑️ agreed by crazycs520.

@AilinKid AilinKid changed the title add system variable for tidb_enable_point_get_plan_cache. add system variable back for tidb_enable_point_get_plan_cache. Mar 31, 2025
Copy link

ti-chi-bot bot commented Mar 31, 2025

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap pingcap deleted a comment from github-actions bot Apr 1, 2025
@pingcap pingcap deleted a comment from github-actions bot Apr 1, 2025
@lilin90
Copy link
Member

lilin90 commented Apr 2, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request reintroduces the tidb_enable_point_get_cache system variable documentation. The change seems straightforward, but I've added a comment to ensure the description is comprehensive.

Merge Readiness

The pull request appears ready for merging, pending resolution of the minor documentation suggestion. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants