Skip to content

Conversation

@wildpcww
Copy link
Collaborator

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added a backup & restore page for premium

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 version
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 20, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2025

Hi @wildpcww. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist
Copy link

Summary of Changes

Hello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new documentation detailing the backup and restore functionalities available for TiDB Cloud Premium instances. The primary goal is to equip users with clear instructions on managing automatic backups, configuring backup settings, and performing data recovery operations, including snapshot and point-in-time restores, to ensure data resilience and minimize potential data loss for their Premium deployments.

Highlights

  • New Documentation Page: A dedicated page, "tidb-cloud/backup-and-restore-premium.md", has been added to provide comprehensive guidance on backup and restore procedures specifically for TiDB Cloud Premium instances.
  • Automatic Backup Settings: The new documentation details the automatic backup capabilities for Premium instances, including configurable backup cycles (daily and hourly), retention policies (up to 33 days), and scheduled backup times.
  • Data Restoration Instructions: The page provides step-by-step guides on how to restore data using both snapshot restore and point-in-time restore methods, specifically for restoring to a new TiDB instance.
  • Recycle Bin Restoration: Guidance is included on how to recover deleted instances from the Recycle Bin, detailing the process to restore backups to a new instance.
  • Limitations Clarification: The documentation explicitly states that manual backups are not supported for TiDB Cloud Premium instances.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation page for backup and restore functionality on TiDB Cloud Premium instances. My review focuses on improving the clarity, consistency, and correctness of the new document, adhering to the repository's style guide. I've identified and suggested fixes for several issues, including typos, grammatical errors, formatting inconsistencies, a broken link, and an incorrect staging URL. Applying these suggestions will enhance the document's quality and user experience.


To restore a deleted instance from recycle bin, take the following steps:

1. Log in to the [TiDB Cloud console](https://tidbcloud.com), and then navigate to the [TiDB instance](https://staging.tidbcloud.com/tidbs?orgId=1369847559692509630&uiMode=new-offerings-preview) page. In the top-right corner, click **Recycle Bin**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The link for "TiDB instance" points to a staging environment with a hardcoded organization ID. This must be replaced with a generic production link. Additionally, there's an extra space after the comma that should be removed.

Suggested change
1. Log in to the [TiDB Cloud console](https://tidbcloud.com), and then navigate to the [TiDB instance](https://staging.tidbcloud.com/tidbs?orgId=1369847559692509630&uiMode=new-offerings-preview) page. In the top-right corner, click **Recycle Bin**.
1. Log in to the [TiDB Cloud console](https://tidbcloud.com), and then navigate to the [**Instances**](https://tidbcloud.com/project/clusters) page. In the top-right corner, click **Recycle Bin**.


4. Click **Next** to proceed to the **Restore to a New TiDB** page.

5. Configure your new TiDB instance for restoration. The steps are the same as [creating a new TiDB instance]()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The link for "creating a new TiDB instance" is empty. Please provide the correct link to the cluster creation documentation.

Suggested change
5. Configure your new TiDB instance for restoration. The steps are the same as [creating a new TiDB instance]()
5. Configure your new TiDB instance for restoration. The steps are the same as [creating a new TiDB instance](/tidb-cloud/create-tidb-cluster-serverless.md).


- Premium instances support both **daily** and **hourly** backups.
- **Default** is **hourly backups**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

This blank line appears to be unnecessary and can be removed for cleaner formatting.

@lilin90 lilin90 self-assigned this Oct 20, 2025
@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Oct 20, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 20, 2025
@lilin90 lilin90 added missing-translation-status This PR does not have translation status info. for-cloud-release This PR is related to TiDB Cloud release. labels Oct 20, 2025
@lilin90 lilin90 self-requested a review October 20, 2025 07:55
@lilin90 lilin90 added area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Oct 20, 2025
@lilin90
Copy link
Member

lilin90 commented Oct 20, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 20, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wildpcww and others added 8 commits October 20, 2025 15:58
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2025

@wildpcww: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 791404f link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants