Skip to content

Conversation

@wildpcww
Copy link
Collaborator

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a user guide doc for Alicloud private link connection.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive documentation for users to establish secure and private connections to their TiDB Cloud Premium instances via Alibaba Cloud's private endpoint service. This new guide aims to simplify the process of integrating TiDB Cloud within a private Alibaba Cloud network, enhancing security and compliance for users who require dedicated network isolation.

Highlights

  • New Documentation: A new user guide has been added for connecting to TiDB Cloud Premium instances using Alibaba Cloud private endpoints.
  • Step-by-Step Guide: The document provides detailed instructions on how to set up a private endpoint on Alibaba Cloud and establish a secure connection to a TiDB instance.
  • Restrictions and Statuses: Information regarding private endpoint restrictions (e.g., cross-region limitations) and a reference for various private endpoint statuses are included.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation file for connecting to TiDB Cloud Premium via Alibaba Cloud Private Endpoint. The review focuses on clarity, grammar, and adherence to the repository's style guide.

wildpcww and others added 2 commits October 22, 2025 17:27
…d-premium.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai qiancai added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. translation/no-need No need to translate this PR. labels Oct 24, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 24, 2025
Renamed the guide for connecting via Alibaba Cloud private endpoint to a new path under 'premium' and updated the TOC reference. Also renamed the related image file for consistency.
@lilin90 lilin90 requested a review from srstack October 31, 2025 10:18
Standardized the phrasing in AWS PrivateLink connection documentation by removing 'Instance' from titles and references. This improves consistency across related guides.
wildpcww and others added 10 commits November 3, 2025 11:25
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 3, 2025
Replaces the existing alicloud-private-endpoint-info.png with a new version to reflect updated information or improved clarity.
@lilin90 lilin90 changed the title tidbcloud: add aliyun private link doc premium: add alibaba cloud private endpoint doc Nov 3, 2025
@lilin90 lilin90 requested a review from qiancai November 3, 2025 07:04
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-03 03:34:12.986893035 +0000 UTC m=+68302.429922914: ☑️ agreed by lilin90.
  • 2025-11-03 08:17:51.303661616 +0000 UTC m=+85320.746691495: ☑️ agreed by qiancai.

lilin90 and others added 4 commits November 4, 2025 15:02
Revised the TOC to add AWS private endpoint connection documentation and updated the Alibaba Cloud link to point to the premium-specific guide for private endpoint connections.
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 4, 2025

@srstack: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 5, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 5, 2025
@ti-chi-bot ti-chi-bot bot merged commit a947af0 into pingcap:release-8.5 Nov 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants