-
Notifications
You must be signed in to change notification settings - Fork 708
v8.5.5: add config for graceful shutdown #22158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
Signed-off-by: hujiatao0 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @hujiatao0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the TiKV configuration documentation by adding a new entry for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the graceful-shutdown-timeout configuration parameter in TiKV. My review focuses on improving the clarity and adhering to the documentation style guide. I've suggested a rephrasing of the parameter description to make it a complete sentence, use active voice, and correctly format the value 0s.
tikv-configuration-file.md
Outdated
| + Minimum value: `"1s"` | ||
|
|
||
| ### `graceful-shutdown-timeout` | ||
| + The timeout duration for graceful shutdown. If the timeout is reached and the leader transfer has not completed, the transfer will be skipped and the node will proceed directly to the shutdown process. A value of 0s disables graceful shutdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity and adhere to the style guide, I suggest rephrasing this description. The current version starts with a sentence fragment and uses passive voice. The suggested change makes it a complete sentence, uses active voice, and formats the 0s value as code for consistency.
| + The timeout duration for graceful shutdown. If the timeout is reached and the leader transfer has not completed, the transfer will be skipped and the node will proceed directly to the shutdown process. A value of 0s disables graceful shutdown. | |
| + Specifies the timeout for graceful shutdown. If the timeout is reached before the leader transfer completes, TiKV skips the transfer and proceeds directly to the shutdown process. To disable graceful shutdown, set the value to `0s`. |
References
- The style guide recommends correcting grammar and avoiding passive voice. The original description starts with a sentence fragment and uses passive voice ('will be skipped'). (link)
- The style guide requires code snippets, command names, options, and paths to be in backticks. The value '0s' should be formatted as
0s. (link)
Signed-off-by: hujiatao0 <[email protected]>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?