build: apply Go dependency security updates to master - #1159
Merged
ti-chi-bot[bot] merged 4 commits intoAug 12, 2026
Conversation
(cherry picked from commit b15ed01)
The prometheus v0.55->v0.312 bump changed the rulefmt.Parse signature and RuleNode->Rule (plain string fields). cmd/main.go was not updated, causing the govulncheck/compile failure reported in review. Also fixes a latent RuleNode cast in pkg/operator/rules.go that would panic at runtime. (cherry picked from commit 35f777f)
|
|
liubog2008
approved these changes
Aug 12, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
The security dependency update from #1132 was applied to the release branch but is not present on
master. The Prometheus dependency update also requires the correspondingrulefmt.ParseAPI migration fixes.This PR brings those fixes to
masterand pins the Go toolchain andgolang.org/x/textto the requested secure versions.What changed?
rulefmt.Parsecall sites and rule type handling for the newer Prometheus API.1.25.12.golang:1.25tag, which tracks the latest 1.25 patch release.golang.org/x/texttov0.39.0and refreshgo.sum.Tests
go test ./pkg/... ./reload/...go test ./cmd/main.gogo build -o /tmp/monitoring-cmd ./cmd/main.gogo build -o /tmp/monitoring-reload ./reload/main.gogo mod verifygit diff --checkThe repository-wide
go test ./...remains unable to build the existingcmdpackage becauseCRD.go,main.go, andmonitoring.goeach definemain; the targeted packages and binaries pass.