Skip to content

codec: add debezium protocol #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 16, 2025
Merged

codec: add debezium protocol #1103

merged 33 commits into from
Apr 16, 2025

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Mar 13, 2025

What problem does this PR solve?

Issue Number: ref #1189

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • debezium basic
  • debezium

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link

ti-chi-bot bot commented Mar 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 13, 2025
@wk989898 wk989898 marked this pull request as ready for review March 14, 2025 04:31
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2025
@asddongmen asddongmen marked this pull request as draft March 21, 2025 01:24
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 14, 2025
@3AceShowHand 3AceShowHand requested a review from Copilot April 14, 2025 08:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 72 out of 76 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • Makefile: Language not supported
  • go.mod: Language not supported
  • pkg/sink/codec/debezium/testdata/datatype.dbz.key.json: Language not supported
  • pkg/sink/codec/debezium/testdata/datatype.ddl.sql: Language not supported
Comments suppressed due to low confidence (1)

pkg/errors/error.go:57

  • Consider updating the error message text to 'unsupported ddl type %s, query %s' for correct grammar.
ErrDDLUnsupportType = errors.Normalize("unsupport ddl type %s, query %s", errors.RFCCodeText("CDC:ErrDDLUnsupportType"))

Copy link

ti-chi-bot bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 14, 2025
Copy link

ti-chi-bot bot commented Apr 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-14 08:15:33.427389048 +0000 UTC m=+2676227.111625136: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 14, 2025
@wk989898 wk989898 closed this Apr 14, 2025
@wk989898 wk989898 reopened this Apr 14, 2025
@wk989898
Copy link
Collaborator Author

/test pull-unit-test

@wk989898
Copy link
Collaborator Author

/test pull-unit-test

1 similar comment
@wk989898
Copy link
Collaborator Author

/test pull-unit-test

Copy link

ti-chi-bot bot commented Apr 16, 2025

@wk989898: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-kafka-integration-light e75323a link false /test pull-cdc-kafka-integration-light
pull-cdc-pulsar-integration-light e75323a link false /test pull-cdc-pulsar-integration-light

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit b9f2312 into pingcap:master Apr 16, 2025
11 of 13 checks passed
@wk989898 wk989898 deleted the debezium branch April 24, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants