Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: retry scatter regions when finished percentage is not 100 | tidb-test=release-8.1.2 #60315

Open
wants to merge 6 commits into
base: feature/release-8.1-gsort-test
Choose a base branch
from

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 28, 2025

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
Copy link

tiprow bot commented Mar 28, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD GMHDBJD changed the title importinot: retry scatter regions when scatter regions finished perce… importinot: retry scatter regions when finished percentage is not 100 Mar 28, 2025
@GMHDBJD GMHDBJD changed the title importinot: retry scatter regions when finished percentage is not 100 importinto: retry scatter regions when finished percentage is not 100 Mar 28, 2025
@GMHDBJD GMHDBJD force-pushed the addFailedRegionIDPick branch from ebc8814 to 9047ed5 Compare March 28, 2025 08:11
@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
@GMHDBJD GMHDBJD changed the base branch from master to feature/release-8.1-gsort-test March 28, 2025 08:12
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2025
@GMHDBJD GMHDBJD changed the title importinto: retry scatter regions when finished percentage is not 100 importinto: retry scatter regions when finished percentage is not 100 | tidb-test=release-8.1.2 Mar 28, 2025
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 28, 2025

/retest

Copy link

tiprow bot commented Mar 28, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/release-8.1-gsort-test@54907f8). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/release-8.1-gsort-test     #60315   +/-   ##
===================================================================
  Coverage                                  ?   71.3970%           
===================================================================
  Files                                     ?       1499           
  Lines                                     ?     432697           
  Branches                                  ?          0           
===================================================================
  Hits                                      ?     308933           
  Misses                                    ?     102471           
  Partials                                  ?      21293           
Flag Coverage Δ
unit 71.2009% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.5568% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

ti-chi-bot bot commented Mar 31, 2025

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 9047ed5 link true /test pull-unit-test-ddlv1
pull-integration-e2e-test 9047ed5 link true /test pull-integration-e2e-test
pull-integration-ddl-test 9047ed5 link false /test pull-integration-ddl-test
pull-lightning-integration-test 9047ed5 link false /test pull-lightning-integration-test
pull-br-integration-test 9047ed5 link false /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 31, 2025
Copy link

ti-chi-bot bot commented Mar 31, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-31 09:27:09.521629582 +0000 UTC m=+1470923.205865680: ☑️ agreed by Benjamin2037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. do-not-merge/needs-linked-issue needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants