planner: fix LogicalProjection.DeriveStats allocate too many memories (#63829) | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944#64006
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5-20241112-v6.5.11from Oct 17, 2025
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
do-not-merge/hold
13 tasks
Member
Author
|
@hawkingrei This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
size/M
Member
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
AilinKid
reviewed
Oct 17, 2025
| if len(exprs) == 0 { | ||
| return nil | ||
| } | ||
| for _, expr := range exprs { |
Contributor
There was a problem hiding this comment.
how about move to here, after all, your func name says it will reuse...
AilinKid
approved these changes
Oct 17, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
hawkingrei
approved these changes
Oct 17, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
hawkingrei
changed the title
Member
|
/retest |
hawkingrei
changed the title
Member
|
/retest |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20241112-v6.5.11 #64006 +/- ##
=================================================================
Coverage ? 73.6241%
=================================================================
Files ? 1097
Lines ? 352967
Branches ? 0
=================================================================
Hits ? 259869
Misses ? 76376
Partials ? 16722 🚀 New features to boost your workflow:
|
ti-chi-bot
bot
merged commit fa8e9d9
into
pingcap:release-6.5-20241112-v6.5.11
10 checks passed
ti-chi-bot
bot
deleted the
cherry-pick-63829-to-release-6.5-20241112-v6.5.11
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #63829
What problem does this PR solve?
Issue Number: close #63810
Problem Summary:
What changed and how does it work?
Previously, we didn't pay attention to reusing the slices of columns, which led to a lot of memory allocation here. We have specially optimized this.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.