Skip to content

expression: UUID_VERSION() and UUID_TIMESTAMP() pushdown to TiKV#65349

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
dveeden:uuid_tikv_pushdown
Jan 13, 2026
Merged

expression: UUID_VERSION() and UUID_TIMESTAMP() pushdown to TiKV#65349
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
dveeden:uuid_tikv_pushdown

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 30, 2025 •
edited
Loading

What problem does this PR solve?

Note, this is on top of #65301

This requires TiKV with tikv/tikv#19254

Issue Number: close #65348

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiKV Pushdown support was added for UUID_VERSION() and UUID_TIMESTAMP()

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-title size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 30, 2025
@dveeden dveeden changed the title TiKV pushdownf or UUID_VERSION and UUID_TIMESTAMP TiKV pushdown or UUID_VERSION and UUID_TIMESTAMP Dec 30, 2025
@tiprow
Copy link

tiprow bot commented Dec 30, 2025

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden requested a review from zanmato1984 December 30, 2025 16:43
@dveeden dveeden changed the title TiKV pushdown or UUID_VERSION and UUID_TIMESTAMP expression: UUID_VERSION() and UUID_TIMESTAMP() pushdown to TiKV Dec 30, 2025
zanmato1984
zanmato1984 reviewed Dec 31, 2025
View reviewed changes
@dveeden dveeden marked this pull request as draft December 31, 2025 08:54
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2025
@dveeden dveeden force-pushed the uuid_tikv_pushdown branch from d6ccf34 to 1d4860c Compare January 6, 2026 20:20
@ti-chi-bot ti-chi-bot bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 6, 2026
@dveeden dveeden marked this pull request as ready for review January 6, 2026 20:20
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 6, 2026
zanmato1984
zanmato1984 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 7, 2026
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2026
@dveeden
Copy link
Contributor Author

dveeden commented Jan 7, 2026

/retest

@tiprow
Copy link

tiprow bot commented Jan 7, 2026

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Jan 7, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.6723%. Comparing base (bedae51) to head (9e83505).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #65349        +/-   ##
================================================
+ Coverage   78.3362%   79.6723%   +1.3360%     
================================================
  Files          1940       1914        -26     
  Lines        535314     541479      +6165     
================================================
+ Hits         419345     431409     +12064     
+ Misses       114449     108647      -5802     
+ Partials       1520       1423        -97
Flag Coverage Δ
integration 47.2389% <38.4615%> (-0.9457%) ⬇️
unit 77.0210% <38.4615%> (+0.5388%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 57.9702% <ø> (+1.3511%) ⬆️
parser ∅ <ø> (∅)
br 64.2860% <ø> (-0.6050%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dveeden
Copy link
Contributor Author

dveeden commented Jan 7, 2026

/retest

@dveeden dveeden mentioned this pull request Jan 7, 2026
Open
14 tasks
windtalker
windtalker approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-07 06:28:40.780482379 +0000 UTC m=+770076.598790811: ☑️ agreed by zanmato1984.
  • 2026-01-13 04:54:47.845794396 +0000 UTC m=+333331.907659307: ☑️ agreed by windtalker.

cfzjywxk
cfzjywxk approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the dep update

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, windtalker, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 13, 2026
@dveeden
Copy link
Contributor Author

dveeden commented Jan 13, 2026

/retest

2 similar comments
@dveeden
Copy link
Contributor Author

dveeden commented Jan 13, 2026

/retest

@dveeden
Copy link
Contributor Author

dveeden commented Jan 13, 2026

/retest

@ti-chi-bot ti-chi-bot bot merged commit 57ad856 into pingcap:master Jan 13, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@windtalker windtalker windtalker approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@0xPoe 0xPoe Awaiting requested review from 0xPoe

Assignees

@bb7133 bb7133

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pushdown for UUID_VERSION() and UUID_TIMESTAMP()

5 participants

@dveeden @zanmato1984 @windtalker @cfzjywxk @bb7133