Refine shared Effect idioms#3090
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Schema.fromJsonString.Duration,DateTime.now,Schedule, and a tagged internal retry signal.TestClock.Why
These changes keep shared runtime code closer to idiomatic Effect patterns: schema-backed parsing, testable Effect time, duration-based policies, and schedule-driven retries without real-time sleeps.
UI Changes
None.
Checklist
Note
Refine DPoP JWT validation and install lock acquisition to use Effect idioms
dpop.tswith schema-based decoders usingOptiontypes, so decoding failures now return specific errors ('Invalid DPoP JWT header.'or'Invalid DPoP JWT payload.') instead of a generic'Invalid DPoP proof.'.relayClient.tswithEffect.retryusing a structuredSchedulepolicy, and extracts stale lock detection intotryAcquireInstallLockusingDateTime/Durationcomparisons.Macroscope summarized e371cc2.