Skip to content

fix: header redaction - #163

Open
sidakram wants to merge 2 commits into
pinojs:masterfrom
sidakram:fix-header-redaction
Open

fix: header redaction#163
sidakram wants to merge 2 commits into
pinojs:masterfrom
sidakram:fix-header-redaction

Conversation

@sidakram

@sidakram sidakram commented Mar 8, 2025

Copy link
Copy Markdown

Redacted certain headers in req/res headers object.
Request headers redacted -

    'cookie',
    'referer',
    'location',
    'geolocation',
    'authorization',
    'x-real-ip',
    'user-agent',
    'x-forwarded-for',
    'proxy-authorization'

Response headers redacted -

    'location',
    'x-real-ip',
    'x-forwarded-for'

targets: #155

@sidakram
sidakram force-pushed the fix-header-redaction branch from efd618d to 9032910 Compare March 8, 2025 20:26

@jsumners jsumners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I think we should omit the headers completely. If someone wants to include them with redaction, and incur the associated cost, they should be able to provide their own serializers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants