Skip to content

fix piohome hang #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 18, 2025
Merged

fix piohome hang #17

merged 10 commits into from
May 18, 2025

Conversation

Jason2866
Copy link

@Jason2866 Jason2866 commented May 18, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue where custom build flags were not correctly reflected in the generated compilation database, ensuring accurate representation in build outputs.
  • Style

    • Updated various user-facing texts to use "PIO Home" instead of "PlatformIO Home" for improved consistency.
  • Chores

    • Internal improvements to configuration handling for package directories; no impact on user-facing functionality.
  • Documentation

    • Added release notes for version 6.1.19.

Jason2866 and others added 9 commits March 19, 2025 17:23
* remove telemetry
* no full git clone
* add intelhex as required
* no core packages
* add `rich_click` as pip dependencies
* remove advertisings
* add intelhex as required
* install scons and Pio home from github
* remove telemetry
* no full git clone
* add intelhex as required
* no core packages
* add `rich_click` as pip dependencies
* remove advertisings
* add intelhex as required
* install scons and Pio home from github
fix Pio home hang
Copy link

coderabbitai bot commented May 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update increments the project version to 6.1.19 and adds a corresponding release note about fixing custom build flag handling in the compilation database. Several internal references to package directories now use the ProjectConfig configuration instead of a direct function call. The ASCII art and help texts for "PlatformIO Home" are updated to "PIO Home".

Changes

File(s) Change Summary
HISTORY.rst Added release note for version 6.1.19 documenting the fix for custom build flags in compile_commands.json.
platformio/init.py Updated VERSION and __version__ constants from 6.1.18 to 6.1.19.
examples/… Updated subproject commit reference for the examples directory.
platformio/builder/tools/piobuild.py Moved the call to env.ProcessCompileDbToolchainOption() within BuildProgram and relocated the function definition for organizational clarity. No logic changes.
platformio/home/cli.py Replaced get_core_package_dir with ProjectConfig for package path resolution; updated help texts and ASCII art from "PlatformIO Home" to "PIO Home".
platformio/home/run.py Replaced get_core_package_dir with ProjectConfig for determining contrib_dir path in run_server.
platformio/remote/cli.py Replaced get_core_package_dir with ProjectConfig for constructing contrib_dir path in the CLI logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant ProjectConfig

    User->>CLI: Start PIO Home or Remote CLI
    CLI->>ProjectConfig: Retrieve packages_dir from config
    ProjectConfig-->>CLI: Return packages_dir path
    CLI->>CLI: Construct contrib_dir path
    CLI->>CLI: Proceed with startup logic (unchanged)
Loading

Poem

🐇
Version hops from eighteen to nineteen,
With flags now true in compile's routine.
"PIO Home" shines with a shorter name,
Paths from configs—no more the same!
A rabbit twitches, quite impressed—
Another update, code refreshed!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 38f61fa and d85b0ba.

📒 Files selected for processing (7)
  • HISTORY.rst (1 hunks)
  • examples (1 hunks)
  • platformio/__init__.py (1 hunks)
  • platformio/builder/tools/piobuild.py (2 hunks)
  • platformio/home/cli.py (3 hunks)
  • platformio/home/run.py (2 hunks)
  • platformio/remote/cli.py (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jason2866 Jason2866 merged commit 91561dd into pio_github May 18, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants