Renamed Attribute to OPMLAttribute, similar to OPMLEntry#3
Open
Vithanco wants to merge 9 commits intopixel-foundry:masterfrom
Open
Renamed Attribute to OPMLAttribute, similar to OPMLEntry#3Vithanco wants to merge 9 commits intopixel-foundry:masterfrom
Vithanco wants to merge 9 commits intopixel-foundry:masterfrom
Conversation
need to change name to OPML Attribute to avoid name clash
need to change name to avoid clashes
changed Attribute to OPMLAttribute
changed Attribute to OPMLAttribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that my source code already had an Attribute class. And I assume that I am not the only one.
I looked at this solution: https://stackoverflow.com/questions/41311213/swift-cant-use-namespace-when-framework-module-with-class-with-same-name, but I thought that a consistent naming in this package would be the better approach.