Skip to content

Fix clamp not updating on screen size changes #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix clamp not updating on screen size changes #517

wants to merge 1 commit into from

Conversation

vnznznz
Copy link

@vnznznz vnznznz commented Mar 13, 2025

When switching to and from fullscreen in my app, the viewport is partially offscreen and only moves back when dragging or zooming. This is because clamp.update ignores screensize changes.

danielbarion
danielbarion approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@danielbarion danielbarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danielbarion danielbarion requested a review from davidfig March 13, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbarion danielbarion danielbarion approved these changes

@davidfig davidfig Awaiting requested review from davidfig

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnznznz @danielbarion