Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command length limitation on Windows in CheckToolBase #5100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nachomata
Copy link

This pull request includes changes to handle long command lines on Windows by creating a response file when necessary, addressing issue #4446. It is solved by creating a response file when necessary, as suggested here.

Changes made:

This is just a quick fix addressing the immediate problem. It might need some extra testing and fine-tuning, so any suggestions would be welcome.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

@ivankravets ivankravets requested a review from valeros March 11, 2025 19:41
@ivankravets ivankravets added this to the 6.1.19 milestone Mar 11, 2025
@valeros
Copy link
Member

valeros commented Mar 13, 2025

Hi @nachomata, thanks for the PR. I'm afraid none of our backend tools for static code analysis (cppcheck, clang-tidy) supports response files at the moment. For cppcheck we already use the --includes-file option that helps shorten the final command line. As for clang-tidy, there is indeed similar option called @parameters_file, but it seems this option cannot be used to pass compilation options (defines, include paths, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants