Skip to content

Update upsun.json #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Update upsun.json #244

merged 2 commits into from
May 5, 2025

Conversation

flovntp
Copy link
Contributor

@flovntp flovntp commented Apr 29, 2025

ps: I'm sorry, as i removed some entire block (like firewall) to replace them by refs (defined at the end, in the definition section), the merge tool is loosing his mind and don't show the right comparison :(

flovntp added 2 commits April 29, 2025 13:59
- Removing dots from title (cf. Let's remove dots for titles. platformsh#243)
- refactor common settings using refs

ps: I'm sorry, as i removed some entire block (like firewall) to replace them by refs (defined at the end, in the `definition` section), the merge tool is loosing his mind and don't show the right comparison :(
change \\n by \n
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit f680d23 into platformsh:main May 5, 2025
@akalipetis akalipetis linked an issue May 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's remove dots for titles.
2 participants